Reduce duplicated warnings for the change of Ruby 3 keyword arguments #2458
Conversation
3581029 to
a5cdbda
Compare
|
In terms of idea, whether we want this feature depends on how annoying we want the warnings to be. If they warn every call, they are very annoying and it will push people to fixing the issue. If they only warn once, they are not that annoying, and people may be less inclined to fix the issue. FYI, I've been working on changes to Note that deduping warnings can already be done in Ruby with minimal code: WARNINGS_SEEN = {}
def Warning.warn(str)
unless WARNINGS_SEEN[str]
WARNINGS_SEEN[str] = true
super
end
endI think the implementation look fine. However, instead of passing through |
a5cdbda to
78e3c68
Compare
|
Huge +1. I don't understand why people can live without this patch. |
78e3c68 to
b21386d
Compare
|
Rebased. I'll create a ticket in the redmine and hear opinions. |
It is a very good point. But I'm afraid if it is too annoying so that people don't use 2.7.
IMO, the check doesn't have to be perfect. It would be enough if it filters many redundant warnings.
It removes not only keyword-related warnings but also other ones. I'm unsure if it is acceptable or not.
Fixed in the above force push. Thank you! |
That actually seems a very useful feature: https://bugs.ruby-lang.org/issues/16345#note-32 |
By this change, the following code prints only one warning.
```
def foo(**opt); end
100.times { foo({kw:1}) }
```
A global variable `st_table *caller_to_callees` is a map from caller to
a set of callee methods. It remembers that a warning is already printed
for each pair of caller and callee.
[Feature #16289]
b21386d to
bc6fb28
Compare
By this change, the following code prints only one warning.
A global variable
st_table *caller_to_callee_to_warnedis a map fromcaller to a set of callee methods. It remembers that a warning is
already printed for each pair of caller and callee.