Say why mathn is deprecated. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the README should also say something to the effect of:
|
And tell people what to do instead. Also, mention its history in the standard libary.
|
Sounds good, I've revised this pull request with a slight rewording of the suggested text regarding its history in the ruby standard library. |
|
@tom-lord Any reactions to the revised wording now pushed to this pull request? Is this ready to merge? |
|
LGTM @jkingdon |
tom-lord
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tell people what to do instead.
I'm open to suggestions about exactly what we should be saying here. But the reason for saying something is so people can better understand what "deprecated" in the name means and what else one can do.