8000 Use gzip tarballs instead of zip archives when possible by jimhester · Pull Request #143 · r-lib/remotes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use gzip tarballs instead of zip archives when possible #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2018
Merged

Use gzip tarballs instead of zip archives when possible #143

merged 2 commits into from
Aug 28, 2018

Conversation

jimhester
Copy link
Member

These are generally smaller and should preserve execute permissions in
all cases, whereas some unzip implementations do not do so.

Fixes r-lib/devtools#1799
Fixes #96

@jimhester jimhester requested a review from gaborcsardi August 27, 2018 16:05
8000
@codecov-io
Copy link
codecov-io commented Aug 27, 2018 •
edited
Loading

Codecov Report

Merging #143 into master will decrease coverage by 7.26%.
The diff coverage is 73.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   93.24%   85.98%   -7.27%     
==========================================
  Files          29       29              
  Lines        1643     1648       +5     
==========================================
- Hits         1532     1417     -115     
- Misses        111      231     +120
Impacted Files Coverage Δ
R/install-local.R 100% <ø> (ø) ⬆️
R/install-url.R 94.11% <ø> (ø) ⬆️
R/install-svn.R 93.24% <0%> (ø) ⬆️
R/git.R 93.93% <100%> (ø) ⬆️
R/utils.R 86.11% <100%> (+0.09%) ⬆️
R/install-remote.R 81.59% <100%> (-12%) ⬇️
R/install-bioc.R 89.92% <50%> (-1.35%) ⬇️
R/install-gitlab.R 90.9% <60%> (-3.54%) ⬇️
R/install-github.R 55.81% <66.66%> (-40.74%) ⬇️
R/install-git.R 90.47% <75%> (-0.99%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd08620...474b0b4. Read the comment docs.

@jimhester
Use gzip tarballs instead of zip archives when possible
760a356 
These are generally smaller and should preserve execute permissions in
all cases, whereas some unzip implementations do not do so.

Fixes r-lib/devtools#1799
Fixes r-lib#96
gaborcsardi
gaborcsardi approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member
@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Is git_extract_sha1_zip() still used after this?

@jimhester
Copy link
Member Author

git_extract_sha1_zip() is not used anymore, I kept it around (with a test) just in case there was a backend that did not support tar.gz, but we could also just remove it entirely.

@jimhester
Remove git_extract_sha1_zip
474b0b4 
It is now unused, as we always download tarballs instead
@jimhester
Copy link
Member Author
jimhester commented Aug 28, 2018 •
edited
Loading

Thanks, I removed the zip implementation.

@jimhester jimhester merged commit 6cba08f into r-lib:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimhester @codecov-io @gaborcsardi
0