feat(desktop): drop-down stub #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimonka83
reviewed
Nov 9, 2020
antongolub
reviewed
Nov 9, 2020
| /> | ||
| stub ? ( | ||
| <Box display="none"> | ||
| {children} |
There was a problem hiding this comment.
А зачем children внутри display=none?
There was a problem hiding this comment.
если в дропдауне будет асинхронный модуль, надо чтобы он на сервере загрузился, и при открытии дропдауна сразу показался серверный стаб
antongolub
previously approved these changes
Nov 9, 2020
dimonka83
previously approved these changes
Nov 9, 2020
dimonka83
previously approved these changes
Nov 9, 2020
dimonka83
approved these changes
Nov 9, 2020
qiwibot
added a commit
that referenced
this pull request
Nov 9, 2020
# [@qiwi/pijma-desktop-v1.115.0](v1.114.2...v1.115.0) (2020-11-09) ### Features * **desktop:** drop-down stub ([#346](#346)) ([a414ee8](a414ee8))
|
🎉 This PR is included in version 1.115.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.