update iguana #203
Merged
update iguana #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates key reflection and conversion logic for the Iguana library along with a version bump in the README.
- In iguana/ylt/reflection/member_count.hpp, the generic branch in the members_count function is split to separately handle aggregate types and unsupported types.
- In iguana/detail/itoa.hpp, explicit template argument syntax is added to the itoa calls for clarity.
- The README version is updated from 1.0.8 to 1.0.9.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iguana/ylt/reflection/member_count.hpp | Updated members_count to handle aggregate types explicitly and add a static_assert branch. |
| iguana/detail/itoa.hpp | Added explicit template arguments to itoa calls for improved template deduction. |
| README.md | Updated version number to reflect the new release. |
| return internal::members_count_impl<type>(); | ||
| } | ||
| else { | ||
| static_assert(!sizeof(T), "not supported type!"); |
There was a problem hiding this comment.
Consider using a more conventional always-false dependent static_assert pattern (e.g., static_assert(always_false::value, "Type T is not supported") ) to enhance clarity.
Suggested change
| static_assert(!sizeof(T), "not supported type!"); | |
| static_assert(always_false<T>::value, "Type T is not supported"); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.