Feature/202505 native preview image #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/qdraw/starsky into feature/202505_native_preview_image
There was a problem hiding this comment.
Pull Request Overview
This PR improves thumbnail handling and database query efficiency while cleaning up unused code and modernizing syntax across the codebase.
- Introduces native preview image generation for macOS and Windows.
- Refactors multiple database query methods and adjusts error logging.
- Implements new thumbnail generation services and updates WebSocket notification handling.
Reviewed Changes
Copilot reviewed 81 out of 81 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| starsky/starsky.foundation.native/PreviewImageNative/*.cs | New native preview image service and helper implementations for macOS and Windows. |
| starsky/starsky.foundation.database/Query/*.cs | Refactored queries with updated error handling, logging, and utilization of new features. |
| starsky/starsky.feature.thumbnail/Services/*.cs | Updated thumbnail generation services, background job service, and WebSocket notification. |
| starsky/starsky.feature.export/Services/ExportService.cs | Adjusted thumbnail generation call with improved ThumbnailGenerationType usage. |
| starsky/package.json | Added a new format script for code formatting. |
starsky/starsky.feature.thumbnail/Services/SmallThumbnailBackgroundJobService.cs
Outdated
Show resolved
Hide resolved
…roundJobService.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description / Motivation and Context
This pull request introduces several changes across multiple files, primarily focusing on improving thumbnail generation, enhancing socket-based communication, and refactoring database query methods. Key updates include the addition of new services for thumbnail management, modifications to existing methods for better functionality, and code cleanup to improve readability and maintainability.
Thumbnail Generation Enhancements:
ISmallThumbnailBackgroundJobServiceand implemented it inSmallThumbnailBackgroundJobServiceto handle background jobs for small thumbnails. This includes queue management and generating thumbnails of typeThumbnailGenerationType.SmallOnly. [1] [2]IThumbnailSocketServiceand implemented it inThumbnailSocketServiceto manage WebSocket notifications for thumbnail updates. This replaces the previousIWebSocketConnectionsServiceusage inManualThumbnailGenerationService. [1] [2] [3]ManualThumbnailGenerationServiceto useThumbnailSocketServicefor sending thumbnail generation results via WebSocket. Removed redundant methods likeWhichFilesNeedToBePushedForUpdates. [1] [2]Database Query Refactoring:
GetAllFilesQueryandGetAllObjectsQuerynow use normalized paths and streamlined logic. [1] [2] [3]LogDebuginstead ofLogInformation).Code Cleanup and Minor Improvements:
ManualThumbnailGenerationServiceandQueryGetAllFiles. This reduces clutter and improves maintainability. [1] [2]IQueryto improve clarity.package.jsonto include a newformatscript for code formatting.These changes collectively enhance the functionality, performance, and maintainability of the codebase, particularly in the areas of thumbnail generation and database operations.
Related Issue
How Has This Been Tested
Types of changes
Checklist