Fetch dependencies using Ivy #1216

tresf · 2023-11-11T07:55:36Z

Removes dependant libraries from the source repository and fetches them from Maven Central using ivy.

tresf · 2023-11-11T08:29:27Z

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

tresf · 2024-03-13T14:54:31Z

It appears javafx.plaform="linux-monocle" is missing in Maven, which is breaking builds for Linux + Intel. I've inquired with Gluon, ticket SUPQZ-18.

Gluon has informed us that linux-monocle is being merged to mainline JavaFX as Headless instead. This is great news. We've provided Gluon with initial test results and they look promising. Once mainline has received the new Headless support, we can move to Ivy for good.

tresf · 2024-12-07T18:53:09Z

Once mainline has received the new Headless support, we can move to Ivy for good.

This has progressed since opening this PR: #1225 (comment). Since "Headless" requires Java 21 or higher, this PR must be merged with #1222 in order to test the headless libraries.

Initial ivy support (squashed)

Deprecated Monocle, add support for Headless

tresf · 2024-12-11T21:17:20Z

This PR is in surprisingly good shape... One outstanding issue is that the JavaFX version that we bundle is currently broken for vector (rasterize: false) prints. We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

tray/ant/ivy-deps.properties

Line 16 in f0cbadf

javafx.version=24-headless+0-2024-12-02-101029

tresf · 2025-03-04T19:20:01Z

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

tresf · 2025-03-04T22:16:59Z

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

So vector prints are fixed, but I've found a bug with raster prints. From what I can tell this issue existed in the last FX snapshot version and I missed it. @akberenz and I spent an hour or so on it, but something with setZoom seems to cause the height on our rasterized-fitted tests to render way too tall. Our tests didn't catch this because the snapshot is actually succeeding, just at an unusual height. Something with the page height calculation is returning values that appear to be using zoom levels from previous snapshots.

tresf · 2025-03-05T22:46:45Z

We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing.

The FX team has provided a patch for vector HTML prints, bumping the version and re-testing.

So vector prints are fixed, but I've found a bug with raster prints. From what I can tell this issue existed in the last FX snapshot version and I missed it. @akberenz and I spent an hour or so on it, but something with setZoom seems to cause the height on our rasterized-fitted tests to render way too tall. Our tests didn't catch this because the snapshot is actually succeeding, just at an unusual height. Something with the page height calculation is returning values that appear to be using zoom levels from previous snapshots.

I was able to reproduce this bug on master branch, so this is no longer a blocker; testing is ready to continue.

tresf · 2025-03-25T17:50:38Z

Tested macOS, Windows 11, Ubuntu 24.04.

No regressions found. Now we wait for a JDK21 JavaFX "Headless" backport.

tresf force-pushed the ivy branch from 2380679 to a05403a Compare November 13, 2023 05:38

tresf mentioned this pull request Oct 23, 2024

Intelij Ant Plugin Missing #1298

Closed

tresf mentioned this pull request Dec 7, 2024

Move away from "Monocle" in favor of "Headless" #1225

Merged

tresf changed the base branch from master to jdk21 December 7, 2024 19:02

Base automatically changed from jdk21 to master December 10, 2024 21:35

Squash PR for fixing conflicts with upstream ivy branch (#7)

5df8544

Initial ivy support (squashed)

tresf force-pushed the ivy branch from 9865ea6 to 5df8544 Compare December 10, 2024 21:47

tresf added 2 commits December 10, 2024 18:03

Move away from "Monocle" in favor of "Headless" (#1225)

72726cc

Deprecated Monocle, add support for Headless

Temporarily switch to JDK23

f0cbadf

tresf added 4 commits March 4, 2025 14:20

Merge branch 'master' into ivy

99af1c8

Bump dependencies

4574ad8

Organize dependencies

348733e

Bump javafx

9429b37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fetch dependencies using Ivy #1216

Fetch dependencies using Ivy #1216

Fetch dependencies using Ivy #1216

Are you sure you want to change the base?

Fetch dependencies using Ivy #1216

Conversation