8000 Flesh out the API docs by SamWilsn · Pull Request #42 · quilt/etk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flesh out the API docs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2021
Merged

Flesh out the API docs #42

merged 2 commits into from
May 8, 2021

Conversation

SamWilsn
Copy link
Contributor
@SamWilsn SamWilsn commented May 7, 2021

No description provided.

@SamWilsn SamWilsn requested a review from lightclient May 7, 2021 20:24
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient reviewed May 8, 2021
View reviewed changes
lightclient
lightclient approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor
@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize there going to be so many "which"s otherwise, probably wouldn't have started commenting :) I think "that" is generally more correct though since "which" is used more when the phrase following is more optional to the sentence.

@SamWilsn SamWilsn merged commit f0b91b6 into master May 8, 2021
@SamWilsn SamWilsn deleted the api-docs branch May 8, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamWilsn @lightclient
0