8000 Renamed `LayoutPrinter` to `LayoutInfo` by MSMazaya · Pull Request #81 · qualcomm/eld · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Renamed LayoutPrinter to LayoutInfo #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Renamed LayoutPrinter to LayoutInfo #81

merged 1 commit into from
May 21, 2025

Conversation

MSMazaya
Copy link
Contributor
@MSMazaya MSMazaya commented May 6, 2025

Renamed all LayoutPrinter related class to LayoutInfo to better match the class usage.

Closes #76

@MSMazaya MSMazaya force-pushed the main branch 2 times, most recently from c25c59a to 66779cb Compare May 6, 2025 15:27
partaror
partaror requested changes May 7, 2025
View reviewed changes
@MSMazaya MSMazaya closed this May 9, 2025
@MSMazaya MSMazaya reopened this May 9, 2025
@MSMazaya MSMazaya requested a review from partaror May 9, 2025 01:29
quic-seaswara
quic-seaswara requested changes May 9, 2025
View reviewed changes
Copy link
Contributor
@quic-seaswara quic-seaswara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

Please squash the commits, and push one pull request.

@MSMazaya MSMazaya force-pushed the main branch 2 times, most recently from 723bfe0 to e29296b Compare May 9, 2025 02:49
@MSMazaya
Copy link
Contributor Author
MSMazaya commented May 9, 2025

Please squash the commits, and push one pull request.

Squashed.

quic-seaswara
quic-seaswara requested changes May 9, 2025
View reviewed changes
Copy link
Contributor
@quic-seaswara quic-seaswara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the changes more carefully, It looks like you have done a sed search and replace, need to be bit more careful.

@MSMazaya MSMazaya requested a review from quic-seaswara May 9, 2025 02:57
@MSMazaya
Copy link
Contributor Author
MSMazaya commented May 9, 2025

Look at the changes more carefully, It looks like you have done a sed search and replace, need to be bit more careful.

Got it, going through the changes to make sure all makes sense.

@partaror
Copy link
partaror commented May 9, 2025

@MSMazaya Can you please update the commit message to use imperative tone in the commit title to stay consistent with good commit-message git conventions?

This might be helpful: https://cbea.ms/git-commit/

partaror
partaror approved these changes May 9, 2025
View reviewed changes
Copy link
@partaror partaror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from one minor nitpick comment.

@MSMazaya MSMazaya force-pushed the main branch 2 times, most recently from c97357c to b13bbc5 Compare May 9, 2025 04:01
quic-seaswara
quic-seaswara reviewed May 15, 2025
View reviewed changes
@MSMazaya MSMazaya force-pushed the main branch 4 times, most recently from dbc0d66 to ee43dbb Compare May 18, 2025 04:30
@MSMazaya MSMazaya requested a review from quic-seaswara May 18, 2025 04:32
@MSMazaya @quic-seaswara
Rename all LayoutPrinter class to LayoutInfo
f85d5a9 
Update `LayoutPrinter` class name to `LayoutInfo` to better reflect their current usage and purpose.

Closes qualcomm#76

Signed-off-by: Muhammad Sulthan Mazaya <msulthanmazaya@gmail.com>
@quic-seaswara quic-seaswara merged commit 7a36913 into qualcomm:main May 21, 2025
4 checks passed
@quic-seaswara
Copy link
Contributor

Thanks for the patch @MSMazaya

Continue to contribute and let us know what you want to work on next ?

@MSMazaya
Copy link
Contributor Author

Happy to contribute @quic-seaswara. I will work on #72 next if that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partaror partaror partaror approved these changes

@quic-seaswara quic-seaswara quic-seaswara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LayoutPrinter should be renamed to LayoutInfo
3 participants
@MSMazaya @partaror @quic-seaswara
0