Feature: cursor.callproc could accept Dict for PostgreSQL 9.0+ named parameters #16 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check-and-conversion chain fixed and simplified. 'spname' was a reference leak.
Temporary anyway: I want to go back returning a list (or dict).
Ifdeffed surface reduced.
…fier in single place
|
Addressed dvarrazzo comments from pull 16. My ref counting might be off for the res = pvals line... it's been a while. |
|
@mrmilosz, @dvarrazzo What's the current status of this feature? |
|
Just waiting for some comments on my latest commit. Code is feature-complete and has unit tests :) |
|
Finally merged to master, to be released in 2.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #16 with new named branch that will be regularly rebased off psycopg/psycopg2 master branch.