8000 Fix mbedtls build by sharkwouter · Pull Request #209 · pspdev/psp-packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix mbedtls build #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix mbedtls build #209

merged 2 commits into from
Apr 7, 2025

Conversation

sharkwouter
Copy link
Member

The download url no longer goes anywhere useful, so I changed the PSPBUILD to use git and pull the commit that corresponds with the release we were already building. I also did some minor consistency fixes in the PSPBUILD.

@isage
Copy link
isage commented Apr 7, 2025 •
edited
Loading

Why use commit when there's https://github.com/Mbed-TLS/mbedtls/archive/refs/tags/v2.16.12.tar.gz

@sharkwouter
Copy link
Member Author

The reason I picked the commit is that tags can be changed and GitHub does not guarantee that release source archives stay the same. So the commit sha is the only safe thing to use.

@isage
Copy link
isage commented Apr 7, 2025

Github actually (so far) guarantees that source archives are immutable
https://github.blog/open-source/git/update-on-the-future-stability-of-source-code-archives-and-hashes/

See, for example, https://github.com/Mbed-TLS/mbedtls/releases/tag/v2.16.12 - it was released 3 years ago, yet sha sum of archives listed in release notes are still valid

@bucanero
Copy link
Contributor
bucanero commented Apr 7, 2025 •
edited
Loading

probably too late, but the Fedora project site hosts the mbedtls packages, here's the link for the v2.16.12:

https://src.fedoraproject.org/repo/pkgs/mbedtls/mbedtls-2.16.12.tar.gz/sha512/8d96d8cd906cc0999134320e4e1f550631426d166eab5da6e65469ee7286093810fcc6ac4bd5500ee55972d159f8bef7f9e53245f7f0eec72f72c35265b4313b/mbedtls-2.16.12.tar.gz

btw, this file is the exact same, and keeps the sha256 sum unmodified 294871ab1864a65d0b74325e9219d5bcd6e91c34a3c59270c357bb9ae4d5c393

bucanero
bucanero reviewed Apr 7, 2025
View reviewed changes
bucanero
bucanero reviewed Apr 7, 2025
View reviewed changes
bucanero
bucanero reviewed Apr 7, 2025
View reviewed changes
bucanero
bucanero reviewed Apr 7, 2025
View reviewed changes
bucanero
bucanero reviewed Apr 7, 2025
View reviewed changes
@sharkwouter sharkwouter merged commit 55311d4 into master Apr 7, 2025
168 checks passed
@sharkwouter
Copy link
Member Author

Thanks for the help @bucanero :D

@sharkwouter sharkwouter deleted the fix-mbedtls branch April 7, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bucanero bucanero bucanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharkwouter @isage @bucanero
0