8000 Fixed Issue #122 Infinite loop by faltiska · Pull Request #124 · psiegman/epublib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Issue #122 Infinite loop #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2019
Merged

Fixed Issue #122 Infinite loop #124

merged 3 commits into from
Dec 3, 2019

Conversation

faltiska
Copy link
Contributor
@faltiska faltiska commented Dec 3, 2019 •
edited
Loading

Fixed Issue #122 Infinite loop.

When reading a file that is not a real zip archive, or from a zero length file, zipInputStream.getNextEntry() throws an exception and does not advance, so loadResources enters an infinite loop.

I also fixed as many audit violations as I could in the test class.

Fixed <a href="https://github.com/psiegman/epublib/issues/122">Issue p…
71999c4 
…siegman#122 Infinite loop</a>.

When reading a file that is not a real zip archive or a zero length file, zipInputStream.getNextEntry() throws an exception and does not advance, so loadResources enters an infinite loop.

I also fixed as many audiot violations as I could in the test class.
@faltiska
Copy link
Contributor Author
faltiska commented Dec 3, 2019

@psiegman please review

psiegman
psiegman reviewed Dec 3, 2019
View reviewed changes
Copy link
Owner
@psiegman psiegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !
Can you fit the typo ? Then I'll merge it.

@psiegman psiegman merged commit c5aafb2 into psiegman:master Dec 3, 2019
hauf-rakuten pushed a commit to hauf-rakuten/epublib that referenced this pull request Nov 10, 2021
@psiegman
Merge pull request psiegman#124 from faltiska/master
4a30a9c 
Fixed Issue psiegman#122 Infinite loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiegman psiegman psiegman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop
2 participants
@faltiska @psiegman
0