8000 Do not rely on Readline being available for Ruby 3.5+ by andrehjr · Pull Request #2349 · pry/pry · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not rely on Readline being available for Ruby 3.5+ #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Do not rely on Readline being available for Ruby 3.5+ #2349

wants to merge 4 commits into from

Conversation

andrehjr
Copy link
Member

This PR intends to fix Readline compatibility with 3.5+. However, other issues that may have changed in Ruby 3.5 still need to be addressed.

Fixes #2348

@andrehjr andrehjr mentioned this pull request Apr 21, 2025
Open
@enescakir
Copy link

Loading pry-0.15.2 in Ruby 3.4.3 gives a warning:

./ruby/3.4.3/lib/ruby/3.4.0/readline.rb:4: warning: reline was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add reline to your Gemfile or gemspec to silence this warning.

Since this PR adds require 'reline', it will continue to show this warning, right?

Should I create a PR to add reline to gemspec file as dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests won't run on Ruby 3.5 not built with --with-readline flag
2 participants
@andrehjr @enescakir
0