8000 Restore pry.config.ls compatibility to previous versions as a Hash by andrehjr · Pull Request #2335 · pry/pry · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restore pry.config.ls compatibility to previous versions as a Hash #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

andrehjr
Copy link
Member

Before #2309, Pry.config.ls was an OpenStruct which allowed colors to be accessed/mutated as a Hash or Methods.

I'm restoring compatibility and adding specs to prevent future regressions.

Fixes #2334

@andrehjr andrehjr force-pushed the make-ls-config-backwards-compat branch from 67ecbc3 to d4d1fce Compare December 15, 2024 20:11
@andrehjr andrehjr marked this pull request as ready for review December 15, 2024 21:26
@andrehjr andrehjr force-pushed the make-ls-config-backwards-compat branch from d4d1fce to 79f1fae Compare December 15, 2024 21:29
@andrehjr andrehjr merged commit e7a5768 into pry:master Dec 15, 2024
19 of 20 checks passed
@andrehjr andrehjr deleted the make-ls-config-backwards-compat branch December 15, 2024 21:42
@andrehjr andrehjr mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible change in Ls::Config
1 participant
0