Delete long_path_not_a_venv since not necessary #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cloning on Windows/using pre-commit hook results in an error for long filename (#744) in
tests/finder/testdata/venvs/long_path_not_a_venv/.... Also tests failed for Windows.Configuring git with
git config --system core.longpaths truesolves the problem for cloning, it will however not solve the usage as a pre-commit hook.Motivation and Context
For testing pathutils the current Test does not use the folder in testdata (also due to a typo in L36 "is_a_venv"). The path is just passed to the is_virtualenv method. Therefore i suggest to just delete the long_path_not_a_venv and its subfolders.
Types of changes
Checklist: