8000 Add GitHub support on formatters by sbrunner · Pull Request #737 · prospector-dev/prospector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add GitHub support on formatters #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Add GitHub support on formatters #737

merged 1 commit into from
Mar 12, 2025

Conversation

sbrunner
Copy link
Member
@sbrunner sbrunner commented Mar 12, 2025

Description

Add annotation on GitHub by using error message

This is used in PyLint and text formatter.

Motivation and Context

Have a better support of the GitHub CI

How Has This Been Tested?

In the pull request I intentionally add an issue and I get:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner force-pushed the github-message branch 6 times, most recently from 62cdae1 to 12bc7c9 Compare March 12, 2025 15:43
@sbrunner sbrunner marked this pull request as ready for review March 12, 2025 15:46
@sbrunner sbrunner changed the title Add GitHub support on PyLint formatter Add GitHub support on formatters Mar 12, 2025
path = location.path
if "PROSPECTOR_FILE_PREFIX" in os.environ:
path = Path(os.environ["PROSPECTOR_FILE_PREFIX"]) / path
# See: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-error-message # pylint: disable=line-too-long
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# See: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-error-message # pylint: disable=line-too-long
# pylint: disable-next=line-too-long
# See: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-error-message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that, thanks :-)

@sbrunner sbrunner merged commit 54d9ddd into master Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0