8000 Fix lint in ingressstatus.go by sunjayBhatia · Pull Request #7023 · projectcontour/contour · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix lint in ingressstatus.go #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Fix lint in ingressstatus.go #7023

merged 1 commit into from
May 5, 2025

Conversation

sunjayBhatia
Copy link
Member

Remove unnecessary intermediate variable

@sunjayBhatia
Fix lint in ingressstatus.go
e7ac8b7 
Remove unnecessary intermediate variable

Signed-off-by: Sunjay Bhatia <sunjay.bhatia@broadcom.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner May 5, 2025 20:30
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team, wilsonwu and davinci26 and removed request for a team May 5, 2025 20:30
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label May 5, 2025
@codecov Codecov
Copy link
codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (154999b) to head (e7ac8b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/contour/ingressstatus.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7023   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         130      130           
  Lines       19694    19693    -1     
=======================================
  Hits        15929    15929           
+ Misses       3479     3478    -1     
  Partials      286      286
Files with missing lines Coverage Δ
cmd/contour/ingressstatus.go 24.79% <0.00%> (+0.20%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sunjayBhatia sunjayBhatia merged commit 0d342ab into projectcontour:main May 5, 2025
28 of 30 checks passed
@sunjayBhatia sunjayBhatia deleted the fixlint-ingressstatus branch May 5, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@skriss skriss Awaiting requested review from skriss skriss is a code owner automatically assigned from projectcontour/maintainers

@wilsonwu wilsonwu Awaiting requested review from wilsonwu wilsonwu was automatically assigned from projectcontour/contour-reviewers

@davinci26 davinci26 Awaiting requested review from davinci26 davinci26 was automatically assigned from projectcontour/contour-reviewers

Assignees
No 4A0A one assigned
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sunjayBhatia
0