8000 Update glide pin for libcalico-go by caseydavenport · Pull Request #1509 · projectcalico/felix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update glide pin for libcalico-go #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2017
Merged

Update glide pin for libcalico-go #1509

merged 1 commit into from
Jul 24, 2017

Conversation

caseydavenport
Copy link
Member
@caseydavenport caseydavenport commented Jul 21, 2017 •
edited by nelljerram
Loading

Description

Pin to libcalico-go 1.5 series.

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

None required

@caseydavenport caseydavenport requested a review from fasaxc July 22, 2017 01:05
@nelljerram nelljerram changed the title Update glide pin for logrus Update glide pin for libcalico-go Jul 24, 2017
nelljerram
nelljerram reviewed Jul 24, 2017
View reviewed changes
Copy link
Member
@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the PR title, as it was talking about logrus for some reason. Otherwise this lgtm, so long as we think it's OK now to use ^x.y style pins for Calico deps.

@fasaxc
Copy link
Member
fasaxc commented Jul 24, 2017

Not 100% sure that's the right call but we can adjust easily enough later on if we change our minds.

@fasaxc fasaxc merged commit 95407da into projectcalico:master Jul 24, 2017
@caseydavenport caseydavenport deleted the 835E update-glide-pins branch July 24, 2017 19:33
song-jiang pushed a commit to song-jiang/felix that referenced this pull request Aug 30, 2017
@fasaxc
Merge pull request projectcalico#1509 from caseydavenport/update-glid…
0da7d8e 
…e-pins

Update glide pin for libcalico-go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelljerram nelljerram nelljerram left review comments

@fasaxc fasaxc fasaxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseydavenport @fasaxc @nelljerram
0