8000 Use SearchBuilder in AdvancedSearchFormComponent spec by jcoyne · Pull Request #3637 · projectblacklight/blacklight · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use SearchBuilder in AdvancedSearchFormComponent spec #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Use SearchBuilder in AdvancedSearchFormComponent spec #3637

merged 1 commit into from
Jun 11, 2025

Conversation

jcoyne
Copy link
Member
@jcoyne jcoyne commented May 30, 2025

This is more like how a Solr::Response is constructed in production

@jcoyne
Use SearchBuilder in AdvancedSearchFormComponent spec
1098fb7 
This is more like how a Solr::Response is constructed in production
@jcoyne jcoyne force-pushed the adv-search-search-builder branch from 127baf7 to 1098fb7 Compare May 30, 2025 22:05
barmintor
barmintor approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor
@barmintor barmintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing it looks like RDoc should be updated for B:S:Response.initialize, but that's a separate issue.

@barmintor barmintor merged commit 7c8b523 into main Jun 11, 2025
11 checks passed
@barmintor barmintor deleted the adv-search-search-builder branch June 11, 2025 16:14
This was referenced Jun 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmintor barmintor barmintor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcoyne @barmintor
0