Default to using Solr real-time get for retrieving single documents #1524
Conversation
| @@ -251,7 +251,7 @@ | |||
| get :show, params: { id: doc_id, format: 'json' } | |||
| expect(response).to be_success | |||
| json = JSON.parse response.body | |||
| expect(json["response"]["document"].keys).to match_array(["author_t", "opensearch_display", "marc_display", "published_display", "author_display", "lc_callnum_display", "title_t", "pub_date", "pub_date_sort", "subtitle_display", "format", "url_suppl_display", "material_type_display", "title_display", "subject_addl_t", "subject_t", "isbn_t", "id", "title_addl_t", "subject_geo_facet", "subject_topic_facet", "author_addl_t", "language_facet", "subtitle_t", "timestamp"]) | |||
| expect(json["response"]["document"].keys).to match_array(["author_t", "marc_display", "published_display", "author_display", "lc_callnum_display", "title_t", "pub_date", "subtitle_display", "format", "url_suppl_display", "material_type_display", "title_display", "subject_addl_t", "subject_t", "isbn_t", "id", "title_addl_t", "subject_geo_facet", "subject_topic_facet", "author_addl_t", "language_facet", "subtitle_t", "timestamp"]) | |||
There was a problem hiding this comment.
Apparently Solr doesn't return any copy fields in the RTG response.
There was a problem hiding this comment.
This should be okay though right? I imagine a copy field would be an odd choice for displaying on the record view.
There was a problem hiding this comment.
Yeah, agreed (and apparently so do the Solr committers), although @erikhatcher has reported it upstream already: https://issues.apache.org/jira/browse/SOLR-8767. If someone does need that behavior, all they need to do is change their defaults.
There was a problem hiding this comment.
Agree here with @jkeck but feels a little bad for some reason. Whats the reason to do the real-time?
There was a problem hiding this comment.
It's there by default, instead of our kinda clunky custom request handler.
b0a5cda to
fd721a0
Compare
1 similar comment
This completes the work started in #1524
No description provided.