8000 Do not install StandardCrypto without web crypto by lauckhart · Pull Request #2204 · project-chip/matter.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not install StandardCrypto without web crypto #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

lauckhart
Copy link
Collaborator

No description provided.

Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR correctly prevents StandardCrypto from being installed when Web Crypto is unavailable. However, the implementation is incomplete, as the StandardCrypto class still has direct dependencies on crypto.subtle that will cause crashes in environments where it's not present. I've also pointed out a questionable dependency addition and a minor typo in the changelog.

Copy link
Collaborator
@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "ProgresS" comment is right from Gemini, rest is fine that way. Thanks

@lauckhart lauckhart force-pushed the handle-missing-crypto branch from 064b50c to 1aa2ab6 Compare June 29, 2025 18:21
@Apollon77 Apollon77 merged commit 0335392 into project-chip:main Jun 29, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0