-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Camera spec pr11597 alignment #38716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marktrayer
wants to merge
16
commits into
project-chip:master
Choose a base branch
from
marktrayer:camera-spec-pr11597-alignmnt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Camera spec pr11597 alignment #38716
marktrayer
wants to merge
16
commits into
project-chip:master
from
marktrayer:camera-spec-pr11597-alignmnt
+1,256
−985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #38716: Size comparison from 5bc0f53 to 56f2f02 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Correctly handle setting of nightvision based on the HAL
PR #38716: Size comparison from 5bc0f53 to 2fe44a7 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #38716: Size comparison from 5bc0f53 to 047132e Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 3, 2025
src/app/zap-templates/zcl/data-model/chip/push-av-stream-transport-cluster.xml
Outdated
Show resolved
Hide resolved
yufengwangca
approved these changes
May 3, 2025
pidarped
reviewed
May 3, 2025
src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml
Show resolved
Hide resolved
pidarped
approved these changes
May 3, 2025
chulspro
approved these changes
May 6, 2025
PR #38716: Size comparison from c91562f to 582ad37 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy generated XML updates based on the spec PR 11597 for CameraAVStreamManagement and PushAVTransport
Also updates the server and delegates for AVStreamManagement to reflect attribute changes
Testing
Zap regen all
Rebuild chip-tool, all-clusters, camera-app
Commission the camera app from chip-tool
Read night-vision related attributes, verify failure as feature not set
Allocate and read snapshot streams