TC OCC 3.1 and 3.2 CI Implementation #34836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding occ test case 3.1 and 3.2
added CI on step 3 and 4
added ci implementation on step 3a and 3c
Added occupancy sensor ci named path implementation
added occ ci named path implemetation
|
Review changes with SemanticDiff. Analyzed 3 of 7 files. Overall, the semantic diff is 59% smaller than the GitHub diff.
|
change to be restyled
restyled
restyled
restyled
restyled
|
PR #34836: Size comparison from 611347e to 0ca1441 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
|
PR #34836: Size comparison from 611347e to ad53ce4 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Implement event handling - Properly implement event checks - Correctly handle HoldTime -> Legacy timing dependencies - Simplify flows - Add missing steps
|
PR #34836: Size comparison from 611347e to c564d8c Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
restyled
restyled
restyled
|
PR #34836: Size comparison from a7dde85 to 8e6a885 Full report (46 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34836: Size comparison from a7dde85 to 1f6af45 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Aug 28, 2024
jmartinez-silabs
approved these changes
Aug 28, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Update tests.yaml adding occ test case 3.1 and 3.2 * Update TC_OCC_3_1.py added CI on step 3 and 4 * Update TC_OCC_3_2.py added ci implementation on step 3a and 3c * Update AllClustersCommandDelegate.cpp Added occupancy sensor ci named path implementation * Update AllClustersCommandDelegate.h added occ ci named path implemetation * Update AllClustersCommandDelegate.cpp change to be restyled * Update TC_OCC_3_1.py restyled * Update TC_OCC_3_2.py restyled * Update TC_OCC_3_1.py restyled * Update TC_OCC_3_2.py restyled * Update TC_OCC_3_1.py sleep module fix * Update TC_OCC_3_2.py sleep module fix * Update TC_OCC_3_2.py restyled * Update TC_OCC_3_1.py minor fixes * Update TC_OCC_3_2.py Added one more write to consider proper callback sequence * Update TC_OCC_3_2.py restyled * Update TC_OCC_3_2.py * Update tests.yaml * Update TC_OCC_3_2.py Fixed a bug on occupancy attribute testing * Update TC_OCC_3_1.py * Update TC_OCC_3_1.py * Update TC_OCC_3_2.py * Update TC_OCC_3_1.py * Update TC_OCC_3_2.py * Update AllClustersCommandDelegate.cpp Removed 1 == endpointId at line 798 Replaced nullptr with reinterpret_cast<void *>(static_cast<uintptr_t>(endpointId)) at line 804 Replaced (1, cleaValue) in line 817 with (static_cast<EndpointId>(reinterpret_cast<uintptr_t>(appState)), clearValue) * Update TC_OCC_3_1.py Modified HoldTime implementation on testing and added Occupancy attribute subscription and event testing in 3.1. * Update TC_OCC_3_1.py * Update TC_OCC_3_1.py * Update AllClustersCommandDelegate.cpp * Update TC_OCC_3_1.py fixed python errors * Update TC_OCC_3_1.py * Update TC_OCC_3_2.py Undated with holdtime testing with holdtime Min/Max * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py * Update TC_OCC_3_2.py * Update .github/workflows/tests.yaml Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update .github/workflows/tests.yaml Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Fix TC-OCC-3.1/3.2 tests - Implement event handling - Properly implement event checks - Correctly handle HoldTime -> Legacy timing dependencies - Simplify flows - Add missing steps * Update AllClustersCommandDelegate.cpp restyled * Update occupancy-sensor-server.cpp restyled * Update TC_OCC_3_1.py restyled * Update TC_OCC_3_2.py restyled * Update matter_testing_support.py restyled * Update TC_OCC_3_2.py * Fix a lint --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement CI for TC OCC 3.1 and 3.2 and upon approval, this should take care of issue #34686.