8000 Log the peer ID when logging operational IP lookup results. by bzbarsky-apple · Pull Request #34381 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log the peer ID when logging operational IP lookup results. #34381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

Log the peer ID when logging operational IP lookup results. #34381

merged 1 commit into from
Jul 18, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

This allows correlating IP results with the peer ID we were resolving.

@github-actions github-actions bot added the lib label Jul 17, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34381: Size comparison from 147f98b to e3d80fa

Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
platform target config section 147f98b e3d80fa change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606578 96 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651910 104 0.0
RAM 204780 204780 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1503028 56 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883108 883176 68 0.0
RAM 142259 142259 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953540 953540 0 0.0
RAM 140687 140687 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828240 68 0.0
RAM 141123 141123 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651532 72 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611992 612064 72 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473864 80 0.0
RAM 144196 144196 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639764 1640016 252 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16308998 16309342 344 0.0
RAM 7161908 7161964 56 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the log-peer-id-for-operational-IPs branch from e3d80fa to 14aeb4e Compare July 17, 2024 22:31
@github-actions GitHub Actions
Copy link
8000 github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34381: Size comparison from 147f98b to 14aeb4e

Full report (6 builds for cc32xx, mbed, stm32, tizen)
platform target config section 147f98b 14aeb4e change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606578 96 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651910 104 0.0
RAM 204780 204780 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1503028 56 0.0
RAM 226648 226648 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473864 80 0.0
RAM 144196 144196 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639764 1640016 252 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16308998 16309342 344 0.0
RAM 7161908 7161964 56 0.0

@bzbarsky-apple
Log the peer ID when logging operational IP lookup results.
f803090 
This allows correlating IP results with the peer ID we were resolving.
@bzbarsky-apple bzbarsky-apple force-pushed the log-peer-id-for-operational-IPs branch from 14aeb4e to f803090 Compare July 17, 2024 22:48
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34381: Size comparison from 147f98b to f803090

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 147f98b f803090 change % change
bl602 lighting-app bl602 FLASH 1271504 1271598 94 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1286018 1286112 94 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1310720 1310814 94 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1092614 1092708 94 0.0
RAM 15161 15161 0 0.0
bl702+mfd FLASH 1103308 1103402 94 0.0
RAM 15313 15313 0 0.0
bl702+rpc FLASH 1182424 1182518 94 0.0
RAM 24181 24181 0 0.0
bl706-eth FLASH 875744 875838 94 0.0
RAM 27272 27272 0 0.0
bl706-wifi FLASH 1128170 1128282 112 0.0
RAM 14605 14605 0 0.0
bl702l lighting-app bl702l FLASH 1079500 1079594 94 0.0
RAM 21732 21732 0 0.0
bl702l+mfd FLASH 1090762 1090856 94 0.0
RAM 21892 21892 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798604 798684 80 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816572 816572 0 0.0
RAM 116948 116948 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808260 808340 80 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760940 761020 80 0.0
RAM 105328 105328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746652 746724 72 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606482 606578 96 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651806 651910 104 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667713 667809 96 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687565 687669 104 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687565 687669 104 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644509 644605 96 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609329 609425 96 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628965 629061 96 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628965 629061 96 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625057 625153 96 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644765 644869 104 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644765 644869 104 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593429 593525 96 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613281 613377 96 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613281 613377 96 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924748 80 0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733996 80 0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012700 1012780 80 0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90924 90924 0 0.0
FLASH 1471102 1471190 88 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1539955 1540051 96 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2627889 2628269 380 0.0
RAM 124496 124496 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5760938 5761290 352 0.0
RAM 493984 493984 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5218822 5219174 352 0.0
RAM 234992 234992 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4615554 4615874 320 0.0
RAM 212256 212256 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12220552 12220904 352 0.0
RAM 548018 548018 0 0.0
chip-tool-ipv6only arm64 unknown 20144 20144 0 0.0
FLASH 10916092 10916348 256 0.0
RAM 597872 597872 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11233657 11233977 320 0.0
RAM 544858 544858 0 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4363350 4363702 352 0.0
RAM 198272 198272 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5539921 5540241 320 0.0
RAM 223520 223520 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4674500 4674852 352 0.0
RAM 199952 199952 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4316560 4316880 320 0.0
RAM 194128 194128 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4455146 4455498 352 0.0
RAM 198680 198680 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2904797 2905181 384 0.0
RAM 152920 152920 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4169804 4170076 272 0.0
RAM 235840 235840 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5816543 5816863 320 0.0
RAM 341360 341360 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10361597 10361917 320 0.0
RAM 402232 402232 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1503028 56 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883108 883176 68 0.0
RAM 142259 142259 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953540 953540 0 0.0
RAM 140687 140687 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828240 68 0.0
RAM 141123 141123 0 0.0
nxp contact k32w0+release FLASH 576164 576164 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 591568 591640 72 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610408 610424 16 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 675192 675272 80 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1616004 1616092 88 0.0
RAM 209764 209764 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536508 1536596 88 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463212 104 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463868 1463956 88 0.0
RAM 224388 224388 0 0.0
qpg lighting-app qpg6105+debug FLASH 651460 651532 72 0.0
RAM 104564 104564 0 0.0
lock-app qpg6105+debug FLASH 611992 612064 72 0.0
RAM 99240 99240 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473864 80 0.0
RAM 144196 144196 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632984 633012 28 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658872 658900 28 0.0
RAM 148436 148436 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779144 779172 28 0.0
RAM 113212 113212 0 0.0
bridge-app tlsr9258a FLASH 675976 676004 28 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634568 634596 28 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720428 720456 28 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613948 613976 28 0.0
RAM 144636 144636 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801730 801758 28 0.0
RAM 103040 103040 0 0.0
lock-app-dfu tlsr9528a FLASH 666384 666412 28 0.0
RAM 69852 69852 0 0.0
ota-requestor-app tlsr9258a FLASH 695308 695336 28 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 616842 616870 28 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607226 607254 28 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466356 466384 28 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641186 641214 28 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651052 651080 28 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 626116 626144 28 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 519342 519370 28 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1639764 1640016 252 0.0
RAM 48620 48620 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16308998 16309342 344 0.0
RAM 7161908 7161964 56 0.0

@mergify mergify bot merged commit d29b350 into project-chip:master Jul 18, 2024
69 checks passed
@bzbarsky-apple bzbarsky-apple deleted the log-peer-id-for-operational-IPs branch July 19, 2024 20:47
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@bzbarsky-apple @j-ororke
Log the peer ID when logging operational IP lookup results. (project-…
996993b 
…chip#34381)

This allows correlating IP results with the peer ID we were resolving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@arkq arkq arkq approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

8000 @ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @arkq
0