Fix crash in TestSecurePairingSession #3357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2020
TestSecurePairingDelegate must live as long as its SecurePairingSession, since the latter holds a pointer to the former. Move SecurePairingSession onto the heap and move TestSecurePairingDelegate to the main test function so its lifetime can be ended after deleting SecurePairingSession. fixes project-chip#3348
677db6c to
08cfda0
Compare
rwalker-apple
approved these changes
Oct 21, 2020
andy31415
approved these changes
Oct 21, 2020
pan-apple
approved these changes
Oct 21, 2020
saurabhst
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSecurePairingDelegate must live as long as its SecurePairingSession,
since the latter holds a pointer to the former.
Move SecurePairingSession onto the heap and move
TestSecurePairingDelegate to the main test function so its lifetime can
be ended beyond deletion of SecurePairingSession.
fixes #3348