8000 Import more message-sending-related code from Silicon Labs (DO NOT SQUASH) by bzbarsky-apple · Pull Request #3296 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Import more message-sending-related code from Silicon Labs (DO NOT SQUASH) #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2020
Merged

Import more message-sending-related code from Silicon Labs (DO NOT SQUASH) #3296

merged 7 commits into from
Oct 21, 2020

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We don't really have a setup for doing unicast sends via bindings right now.

Summary of Changes

Pull in the Silicon Labs code that handles a bunch of the infrastructure for this and use it to enable unicast send via bindings.

Fixes #2504

Please DO NOT SQUASH when merging.

@bzbarsky-apple bzbarsky-apple force-pushed the import-more-sending-stuff branch 8 times, most recently from c267574 to 370b9f9 Compare October 19, 2020 21:42
@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-lighting.elf text 780 780
chip-lighting.elf bss 0 324
chip-lighting.elf [LOAD #1 [RWX]] 4 4
chip-lighting.elf [LOAD #3 [RW]] 0 -4
chip-lock.elf text 780 780
chip-lock.elf bss 0 324
chip-lock.elf [LOAD #1 [RWX]] 4 4
chip-lock.elf [LOAD #3 [RW]] 0 -4
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,19058
.debug_loc,0,4717
.debug_line,0,4468
.debug_abbrev,0,2329
.debug_str,0,1703
text,780,780
.debug_frame,0,772
.symtab,0,608
.strtab,0,441
.debug_ranges,0,408
bss,324,0
.debug_aranges,0,240
[LOAD #1 [RWX]],4,4
[LOAD #3 [RW]],-4,0

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,19052
.debug_loc,0,4717
.debug_line,0,4459
.debug_abbrev,0,2329
.debug_str,0,1703
text,780,780
.debug_frame,0,776
.symtab,0,608
.strtab,0,441
.debug_ranges,0,408
bss,324,0
.debug_aranges,0,240
[LOAD #1 [RWX]],4,4
[LOAD #3 [RW]],-4,0
[Unmapped],0,-5

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.text 1040 1040
chip-wifi-echo.elf .dram0.bss 0 80
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,11278
.debug_line,0,4984
.debug_loc,0,2122
.debug_str,0,1444
.debug_abbrev,0,1237
.flash.text,1040,1040
.debug_frame,0,520
.strtab,0,514
.debug_ranges,0,304
.symtab,0,288
.debug_aranges,0,192
.dram0.bss,80,0
[Unmapped],0,1

@bzbarsky-apple bzbarsky-apple changed the title Import more message-sending-related code from Silicon Labs Import more message-sending-related code from Silicon Labs (DO NOT SQUASH) Oct 19, 2020
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review October 19, 2020 22:15
@bzbarsky-apple
Copy link
Contributor Author

A note to reviewers: The first 2 commits are from the Silicon Labs code contribution and the third one is mechanical restyling. The interesting bits are in the remaining commits, which might be simplest to review one at a time: the fourth one is mostly removing code I think we don't need, the fifth is actually a substantive change to how we pass around node ids in some functiosn, the sixth is a rename with no functionality changes, and the seventh is the actual fix for #2504

@bzbarsky-apple bzbarsky-apple marked this pull request as draft October 19, 2020 22:21
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review October 20, 2020 15:12
@bzbarsky-apple
Make af-main-common.c compile.
032578c 
1) Comment out nonexistent includes.
2) Adjust naming for includes in the gen/ directory.
3) Remove various functions that we don't actually need for
   our main purpose of sending messages.
4) Don't try to print a pretty name for the profile id in
   printMessage.
5) Get rid of branches that have to do with EMBER_ZDO_PROFILE_ID,
   because those will look different in CHIP anyway.
6) Add a stub implementation of emAfSend, to be filled out later.
7) Adjust the way we handle group bindings to the changed group
   id storage.
@bzbarsky-apple
Go back to using emberAfSendUnicastWithCallback for sending unicast r…
57683c1 
…esponses.
@bzbarsky-apple
Rename chip-response to make it clearer what it actually does.
2e738a4 
Right now it supports sending unicast messages.
@bzbarsky-apple
Enable unicast sends to bindings in src/app
22003f2
@bzbarsky-apple bzbarsky-apple force-pushed the import-more-sending-stuff branch from 370b9f9 to 22003f2 Compare October 20, 2020 16:23
@bzbarsky-apple
Copy link
Contributor Author

@saurabhst @BroderickCarlin could you take a look? Marking as draft again so it doesn't get accidentally squashed, but this is ready for review and non-squashed landing.

@bzbarsky-apple bzbarsky-apple marked this pull request as draft October 21, 2020 04:07
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review October 21, 2020 04:09
@bzbarsky-apple bzbarsky-apple merged commit 80240a6 into project-chip:master Oct 21, 2020
@bzbarsky-apple bzbarsky-apple deleted the import-more-sending-stuff branch October 21, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang approved these changes

@saurabhst saurabhst saurabhst approved these changes

@rwalker-apple rwalker-apple rwalker-apple approved these changes

@shana-apple shana-apple Awaiting requested review from shana-apple

@pan-apple pan-apple Awaiting requested review from pan-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@wehale wehale Awaiting requested review from wehale

Assignees
No one assigned
Labels
app examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace SEND_COMMAND_UNICAST_TO_BINDINGS
5 participants
@bzbarsky-apple @mspang @saurabhst @rwalker-apple @selissia
0