8000 Restyle [samples/nrfconnect] Added updating ZCL cluster state to fit actual light/lock state. by restyled-io[bot] · Pull Request #3218 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restyle [samples/nrfconnect] Added updating ZCL cluster state to fit actual light/lock state. #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Restyle [samples/nrfconnect] Added updating ZCL cluster state to fit actual light/lock state. #3218

wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor
@restyled-io restyled-io bot commented Oct 13, 2020

A duplicate of #3132 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions 
    ```console
git remote add upstream https://github.com/project-chip/connectedhomeip.git
git fetch upstream pull/<this PR number>/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

kkasperczyk-no and others added 2 commits October 13, 2020 17:11
@kkasperczyk-no
[example/nrfconnect] Added updating ZCL cluster state to meet with ac…
dc4b68b 
…tual light/lock state.

Initial value of ZCL ON/OFF cluster is not defined,
while the lock/lighting is initially turned on in nRF Connect examples.

* Added UpdateClusterState method called on the cluster post init callback and each completed
on/off action.
* Removed emberAfPluginOnOffClusterServerPostInitCallback method implementation from callback-stub.c
files for lighting and lock apps.
* Added emberAfPluginOnOffClusterServerPostInitCallback method empty implementations
for all platforms supporting lighting/lock app.
@restyled-commits
Restyled by clang-format
d1241a5
@restyled-io restyled-io bot added the restyled label Oct 13, 2020
@restyled-io restyled-io bot closed this Oct 13, 2020
@restyled-io restyled-io bot deleted the restyled/pull-3132 branch October 13, 2020 15:18
@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-lock.elf text 94 94
chip-lock.elf rodata 24 24
chip-lock.elf bss 0 4
chip-lock.elf [LOAD #1 [RWX]] 2 2
chip-lock.elf [LOAD #3 [RW]] 0 -4
chip-lighting.elf text 108 108
chip-lighting.elf noinit 0 40
chip-lighting.elf rodata 24 24
chip-lighting.elf [LOAD #1 [RWX]] -12 -12
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,3233
.debug_line,0,512
.debug_loc,0,231
text,94,94
.symtab,0,80
.debug_abbrev,0,78
.debug_str,0,66
.strtab,0,31
.debug_frame,0,24
rodata,24,24
.debug_aranges,0,16
bss,4,0
[LOAD #1 [RWX]],2,2
[Unmapped],0,1
[LOAD #3 [RW]],-4,0
.debug_ranges,0,-8

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,3867
.debug_line,0,523
.debug_loc,0,447
.debug_abbrev,0,211
text,108,108
.symtab,0,80
.debug_str,0,66
.debug_frame,0,44
noinit,40,0
.strtab,0,38
.debug_ranges,0,24
rodata,24,24
.debug_aranges,0,16
[Unmapped],0,-8
[LOAD #1 [RWX]],-12,-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples restyled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkasperczyk-no @restyled-commits
0