-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ICD] ICD registration in AutoCommissioner #30260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] ICD registration in AutoCommissioner #30260
Conversation
PR #30260: Size comparison from 2338544 to 63420ad Increases above 0.2%:
Increases (3 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
63420ad
to
2f71aa1
Compare
PR #30260: Size comparison from 6d9cb39 to 2f71aa1 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
2f71aa1
to
e68a9cc
Compare
PR #30260: Size comparison from 6d9cb39 to e68a9cc Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
e68a9cc
to
9115154
Compare
PR #30260: Size comparison from 6d9cb39 to 9115154 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
9115154
to
1f6fc9a
Compare
1f6fc9a
to
26aabdb
Compare
26aabdb
to
0894b51
Compare
PR #30260: Size comparison from 03efab5 to d454798 Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for linux)
Full report (60 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30260: Size comparison from 03efab5 to e379c8a Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "changes requested" is because this is broken with non-concurrent flows...
PR #30260: Size comparison from 03efab5 to 959f905 Increases above 0.2%:
Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (4 builds for psoc6)
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
25180e2
to
1bee2d3
Compare
…r-registration-interface-29389
PR #30260: Size comparison from 223c054 to df9e22a Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for efr32)
|
74bad8e
to
2df47a6
Compare
2df47a6
to
3c70693
Compare
PR #30260: Size comparison from 26b0bbf to 3c70693 Increases above 0.2%:
Increases (3 builds for linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@@ -776,6 +827,15 @@ CHIP_ERROR AutoCommissioner::CommissioningStepFinished(CHIP_ERROR err, Commissio | |||
// storing the returned certs, so just return here without triggering the next stage. | |||
return NOCChainGenerated(report.Get<NocChain>().noc, report.Get<NocChain>().icac, report.Get<NocChain>().rcac, | |||
report.Get<NocChain>().ipk, report.Get<NocChain>().adminSubject); | |||
case CommissioningStage::kICDGetRegistrationInfo: | |||
// Noting to od. The ICD registation info is handled elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to do". Same for all the other new comments..... Please be more careful.
} | ||
else | ||
{ | ||
commissioner->CommissioningStageComplete(CHIP_ERROR_INCORRECT_STATE, report); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right. If deviceBeingCommissioned
is null, we are not in commissioning anymore and must not call CommissioningStageComplete....
This PR implements the ICDOnRegistraionComplete for applications handle the ICD Counter and do necessary operations to persist the key.
CHIP Tool is also updated to receive infos for ICD registration.
#29385