8000 Fix uninitialised values in KeySet and AttributePathExpandIterator by DamMicSzm · Pull Request #28356 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix uninitialised values in KeySet and AttributePathExpandIterator #28356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue 8000 and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Fix uninitialised values in KeySet and AttributePathExpandIterator #28356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3aa768
Fix uninitialised value in KeySet
DamMicSzm Jul 26, 2023
cef1b75
Fix uninitilised mGlobalAttributeEndIndex
DamMicSzm Jul 27, 2023
be22ef1
Restyled by clang-format
restyled-commits Jul 28, 2023
2ad9f75
Review proposed change initilize mGlobalAttributeEndIndex
DamMicSzm Jul 31, 2023
94157b6
Change initialize values in KeySet to initilize only start_time in Ep…
DamMicSzm Jul 31, 2023
cf7e1e4
Restyled by clang-format
restyled-commits Jul 31, 2023
5cdefd8
Review proposed change initilize IPK keyset start_time
DamMicSzm Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/app/AttributePathExpandIterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ void AttributePathExpandIterator::PrepareAttributeIndexRange(const AttributePath
}
mGlobalAttributeEndIndex = static_cast<uint8_t>(mGlobalAttributeIndex + 1);
}
else
{
mGlobalAttributeIndex = UINT8_MAX;
mGlobalAttributeEndIndex = 0;
}
}
}

Expand Down
7 changes: 4 additions & 3 deletions src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,9 +654,10 @@ bool emberAfOperationalCredentialsClusterAddNOCCallback(app::CommandHandler * co

// Set the Identity Protection Key (IPK)
// The IPK SHALL be the operational group key under GroupKeySetID of 0
keyset.keyset_id = Credentials::GroupDataProvider::kIdentityProtectionKeySetId;
keyset.policy = GroupKeyManagement::GroupKeySecurityPolicyEnum::kTrustFirst;
keyset.num_keys_used = 1;
keyset.keyset_id = Credentials::GroupDataProvider::kIdentityProtectionKeySetId;
keyset.policy = GroupKeyManagement::GroupKeySecurityPolicyEnum::kTrustFirst;
keyset.num_keys_used = 1;
keyset.epoch_keys[0].start_time = 0;
memcpy(keyset.epoch_keys[0].key, ipkValue.data(), Crypto::CHIP_CRYPTO_SYMMETRIC_KEY_LENGTH_BYTES);

err = newFabricInfo->GetCompressedFabricIdBytes(compressed_fabric_id);
Expand Down
0