8000 [nRF Connect] Print PIN and QR Code on door-lock startup by Damian-Nordic · Pull Request #2335 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[nRF Connect] Print PIN and QR Code on door-lock startup #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2020
Merged

[nRF Connect] Print PIN and QR Code on door-lock startup #2335

merged 3 commits into from
Aug 29, 2020

Conversation

Damian-Nordic
Copy link
Contributor

Problem

nRF Connect door-lock example doesn't print PIN and QR Code on startup while the nRF5 example does.

Summary of Changes

Print PIN and QR Code on nRF Connect door-lock startup

fixes #2334

@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf text 145820 145820
chip-nrf52840-lock-example.elf rodata 15792 15792
chip-nrf52840-lock-example.elf bss 0 5736
chip-nrf52840-lock-example.elf datas 603 603
chip-nrf52840-lock-example.elf init_array 28 28
chip-nrf52840-lock-example.elf [LOAD #2 [RW]] 5 5
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -8 -8
chip-nrf52840-lock-example.elf [LOAD #3 [RW]] 0 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,307748
.debug_str,0,166049
text,145820,145820
.strtab,0,131628
.debug_frame,0,105832
.symtab,0,88992
.debug_line,0,35394
rodata,15792,15792
.debug_abbrev,0,12347
.debug_ranges,0,6696
.debug_loc,0,6572
bss,5736,0
.debug_aranges,0,4760
datas,603,603
init_array,28,28
[LOAD #2 [RW]],5,5
[Unmapped],0,2
[LOAD #1 [RWX]],-8,-8
[LOAD #3 [RW]],-8,0

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_efr32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-efr32-lock-example.out and ./pull_artifact/chip-efr32-lock-example.out:

sections,vmsize,filesize

@rwalker-apple rwalker-apple merged commit 14ff0cc into project-chip:master Aug 29, 2020
@Damian-Nordic Damian-Nordic deleted the feature/printqr branch September 9, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang approved these changes

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@rwalker-apple rwalker-apple rwalker-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

731D @chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
config examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nRF Connect] Print PIN and QR Code on door-lock startup
7 participants
@Damian-Nordic @mspang @andy31415 @saurabhst @woody-apple @rwalker-apple @ktaborowski
0