8000 Align joiner functionality on ncs example with other platforms by ktaborowski · Pull Request #2261 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Align joiner functionality on ncs example with other platforms #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2020
Merged

Align joiner functionality on ncs example with other platforms #2261

merged 3 commits into from
Aug 21, 2020

Conversation

ktaborowski
Copy link
Contributor

Problem

Example lock-app for the nrfconnect platform does not support Thread Joiner role.

Summary of Changes

Add a Thread Joiner to an example. The Joiner is activated by pressing button 3 on nRF52 DK board.
New behavior is described in README file.

@CLAassistant
Copy link
CLAassistant commented Aug 20, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Aug 20, 2020
Closed
@ktaborowski ktaborowski force-pushed the Align-joiner-functionality-on-ncs-example-with-other-platforms branch from 12c2809 to f828a7c Compare August 20, 2020 13:03
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-nrf52840-lock-example.elf text 3416 3416
chip-nrf52840-lock-example.elf rodata 276 276
chip-nrf52840-lock-example.elf bss 0 104
chip-nrf52840-lock-example.elf [LOAD #1 [RWX]] -8 -8
chip-nrf52840-lock-example.elf [LOAD #3 [RW]] 0 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize
.debug_info,0,601566
.debug_line,0,18192
.debug_loc,0,11991
.debug_abbrev,0,10638
.debug_str,0,5459
.strtab,0,3440
text,3416,3416
.symtab,0,2240
.debug_ranges,0,1776
.debug_frame,0,1236
.debug_aranges,0,424
rodata,276,276
bss,104,0
[Unmapped],0,-6
[LOAD #1 [RWX]],-8,-8
[LOAD #3 [RW]],-8,0

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@woody-apple woody-apple merged commit 6bb7ff6 into project-chip:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jelderton jelderton jelderton approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
config examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ktaborowski @CLAassistant @andy31415 @saurabhst @woody-apple @jelderton
0