-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[YAML] Allow contains/exclude constraints to be used for bitmaps #20359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vivien-apple
merged 3 commits into
project-chip:master
from
vivien-apple:YAML_AllowContainsExcludesForBitmaps
Jul 8, 2022
Merged
[YAML] Allow contains/exclude constraints to be used for bitmaps #20359
vivien-apple
merged 3 commits into
project-chip:master
from
vivien-apple:YAML_AllowContainsExcludesForBitmaps
Jul 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Jul 6, 2022
51c608d
to
c583861
Compare
c583861
to
1158db7
Compare
PR #20359: Size comparison from 126f6b2 to 1158db7 Increases (4 builds for cc13x2_26x2, efr32, linux, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
1158db7
to
343216e
Compare
PR #20359: Size comparison from 9e982ce to 343216e Increases (4 builds for cc13x2_26x2, esp32, linux)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 7, 2022
343216e
to
3cbd574
Compare
…elds that should or should not be contained
3cbd574
to
27b63fa
Compare
PR #20359: Size comparison from 996f5f3 to 27b63fa Increases (4 builds for k32w, linux, telink)
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
27b63fa
to
01e6556
Compare
PR #20359: Size comparison from 996f5f3 to 01e6556 Increases (5 builds for esp32, k32w, linux, telink)
Decreases (1 build for nrfconnect)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
added a commit
that referenced
this pull request
Jul 8, 2022
) (#20483) Co-authored-by: Vivien Nicolas <vnicolas@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Instead of checking an exact value for a bitmap attribute or the
FeatureMap
attribute, one may want to check for the presence of a given flag.Change overview