8000 Fixing endpoint config generation for string type attributes by brdandu · Pull Request #1595 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing endpoint config generation for string type attributes #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Fixing endpoint config generation for string type attributes #1595

merged 1 commit into from
May 9, 2025

Conversation

brdandu
Copy link
Collaborator
@brdandu brdandu commented May 9, 2025

Generating correctly for string type attributes which have numbers only as their default values when using helper-endpointconfig.js

Github: ZAP#1504

@brdandu
Generating correctly for string type attributes which have numbers on…
9ced221 
…ly as their default values when using helper-endpointconfig.js

Github: ZAP#1504
@brdandu brdandu requested review from paulr34 and tecimovic as code owners May 9, 2025 17:50
@brdandu brdandu linked an issue May 9, 2025 that may be closed by this pull request
ZAP can't generate correct default values for string type attributes with a numeric value assigned #1504
Closed
@brdandu brdandu merged commit 8043f56 into project-chip:master May 9, 2025
13 checks passed
@brdandu brdandu deleted the bug/stringTypesGeneratingIncorrectOutputForNumbers/ZAP#1504 branch May 9, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecimovic tecimovic tecimovic approved these changes

@ethanzhouyc ethanzhouyc ethanzhouyc approved these changes

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@dhchandw dhchandw Awaiting requested review from dhchandw

@paulr34 paulr34 Awaiting requested review from paulr34 paulr34 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZAP can't generate correct default values for string type attributes with a numeric value assigned
3 participants
@brdandu @tecimovic @ethanzhouyc
0