ide integration fix #1587
ide integration fix #1587
Conversation
There was a problem hiding this comment.
Seems OK from the Zigbee side.
At one point I was seeing some odd behavior with the [ --generationTemplate ${zcl.zigbeeTemplateJsonFile} ] argument not getting parsed until I tested removing the [ --zcl ${zcl.matterZclJsonFile ] argument right before it; the parsing remained fixed even after restoring the matter argument, though. It would probably be useful to at least have some way to explain that behavior, but any other issues I may have seen locally would not be coming from ZAP.
There was a problem hiding this comment.
Feel free to merge after the following test cases are running without issues:
- ZAP works with SDK that does not have "uc.sdkProvidedProperties": "zcl.matterZclJsonFile,zcl.matterTemplateJsonFile,zcl.zigbeeZclJsonFile,zcl.zigbeeTemplateJsonFile", defined. Open Extensions pane in ZAP UI and see if the right packages are loaded in it.
- ZAP works with the SDK which has "uc.sdkProvidedProperties": "zcl.matterZclJsonFile,zcl.matterTemplateJsonFile,zcl.zigbeeZclJsonFile,zcl.zigbeeTemplateJsonFile", defined. Open Extensions pane in ZAP UI and see if the right packages are loaded in it.
- Upgrade a .zap application created with step 1 to a SDK of step 2 and make sure it updates without any errors. Open extensions pane in ZAP UI and see if the packages from SDK in step 2 show up there.
5f88a72 to
3bc3825
Compare
There was a problem hiding this comment.
This makes little sense to me....
We have two possibilities: either you get sdkRoot or you get that new-fangled thing, the zcl.whatever.
If this is the case, then this should be the [ .... | .... ] construct, or possibly { ... | ... } one.
But simply adding the new mechanism through [ .... ] makes no sense.
fixed, thanks |
|
Makes more sense now. Assuming you've tested, I'm ok with this. |
agreed. thank you. will run it through another round of testing with sdk teams |
No description provided.