Fix the Legal Clusters view where users will only see clusters associated with a device type and not just enabled clusters which is wrong #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Use the device types on the selected endpoint to figure out the device type clusters and then only show those clusters in the UI.
- The Legal clusters UI view will also not allow users to enable/disable non compliant clusters and also not show non compliant clusters.
- Github: ZAP#316
|
@mlepage-google @bzbarsky-apple , Added you too, just a FYI and if you guys wanted to try the feature before it is merged. Feel free to ignore the PR review process. However, all reviews are appreciated. |
tecimovic
approved these changes
Apr 11, 2025
paulr34
reviewed
Apr 11, 2025
| ) | ||
| p.push( | ||
| axiosRequests | ||
| .$serverGet( | ||
| `${restApi.uri.deviceTypeAttributes}${endpointTypeDeviceTypeRefPair.deviceTypeRef}` |
There was a problem hiding this comment.
Why did you do this? I'm lost
There was a problem hiding this comment.
This was all broken when multiple device type refs are passed(Which happens when user selects more than one device type on an endpoints). The URIs were like Identify/1,2 which would return nothing. Now it does Identify/1 and Identify/2` and collates the 2 results.
Am surprised no one has complained about this yet.
paulr34
approved these changes
Apr 11, 2025
8000
…ated with a device type and not just enabled clusters which is wrong - Use the device types on the selected endpoint to figure out the device type clusters and then only show those clusters in the UI. - The Legal clusters UI view will also not allow users to enable/disable non compliant clusters and also not show non compliant clusters. - Adding cypress tests for filters of legal and enabled clusters - Add more tests where the clusters are check for enablement when clicking on the client and server checkboxes - Github: ZAP#316
2055d65 to
b0e829c
Compare
tbrkollar
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.