Increasing timeout because for now it is not reasonable for all machines #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Apr 3, 2025
tecimovic
approved these changes
Apr 3, 2025
| @@ -70,7 +70,7 @@ const precompiledTemplates = {} | |||
|
|
|||
| const handlebarsInstance = {} | |||
|
|
|||
| const TEMPLATE_RENDER_TIMEOUT = 90000 // 90 seconds | |||
| const TEMPLATE_RENDER_TIMEOUT = 540000 // 9 minutes | |||
There was a problem hiding this comment.
better, but I'd kill this, and replace it with a proper watchdog
42e40de to
41396d9
Compare
dhchandw
approved these changes
Apr 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
==========================================
- Coverage 66.93% 66.86% -0.07%
==========================================
Files 197 198 +1
Lines 21827 22008 +181
Branches 4817 4857 +40
==========================================
+ Hits 14609 14716 +107
- Misses 7218 7292 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
41396d9 to
defcf53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.