8000 Cluster Feature Page - Display Feature Info by ethanzhouyc · Pull Request #1544 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cluster Feature Page - Display Feature Info #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

ethanzhouyc
Copy link
Collaborator
@ethanzhouyc ethanzhouyc commented Mar 24, 2025
  • Implemented the Cluster Feature page to display feature details and enabled status based on cluster XML definitions.
    (Note: Feature toggling is currently disabled and will be enabled in a future PR.)
  • Displayed the FeatureMap Attribute Value on the top right corner of the page to assist with feature configuration.
  • Added backend logic and REST APIs
  • Added unit test for API getting featureMap attribute value

ZAPP-1547

Copy link
Collaborator
@paulr34 paulr34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In person review.

@ethanzhouyc ethanzhouyc changed the title Cluster Feature Page - Display Feature Info (Backend & REST API) Cluster Feature Page - Display Feature Info Mar 27, 2025
@ethanzhouyc ethanzhouyc requested a review from tbrkollar March 27, 2025 19:10
<div class="col-2">
<q-input v-model="featureMapValue" dense outlined disable />
</div>
</div>
Copy link
Collaborator Author
@ethanzhouyc ethanzhouyc Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbrkollar I added a label and a q-input to display the FeatureMap Attribute Value, but as shown in the screenshot below, the layout doesn't look great. Could you help see how to improve the UI? Feel free to move it anywhere on the page where it fits best. Thank you!

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to advice from @tbrkollar, the featureMap Attribute Value is moved to the right top corner and looks much better now.
image

8000
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.15789% with 28 lines in your changes missing coverage. Please review.

Project coverage is 66.86%. Comparing base (dc0747a) to head (29afa52).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ZclDeviceTypeFeatureManager.vue 0.00% 7 Missing ⚠️
src/store/zap/actions.js 0.00% 7 Missing ⚠️
src/components/ZclClusterFeatureManager.vue 73.33% 4 Missing ⚠️
src/store/zap/mutations.js 0.00% 4 Missing ⚠️
src-electron/db/query-feature.js 66.66% 3 Missing ⚠️
src/components/ZclDomainClusterView.vue 0.00% 2 Missing ⚠️
src-electron/rest/user-data.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
- Coverage   66.93%   66.86%   -0.08%     
==========================================
  Files         197      198       +1     
  Lines       21827    22001     +174     
  Branches     4817     4855      +38     
==========================================
+ Hits        14609    14710     +101     
- Misses       7218     7291      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ethanzhouyc
Copy link
Collaborator Author

Issue #1563 created to add Cypress tests covering the feature page related code in future PR

@ethanzhouyc ethanzhouyc merged commit 3375934 into project-chip:master Apr 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0