-
Notifications
You must be signed in to change notification settings - Fork 87
Cluster Feature Page - Display Feature Info #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In person review.
<div class="col-2"> | ||
<q-input v-model="featureMapValue" dense outlined disable /> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbrkollar I added a label and a q-input to display the FeatureMap Attribute Value, but as shown in the screenshot below, the layout doesn't look great. Could you help see how to improve the UI? Feel free to move it anywhere on the page where it fits best. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to advice from @tbrkollar, the featureMap Attribute Value is moved to the right top corner and looks much better now.
d5359de
to
29afa52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 66.93% 66.86% -0.08%
==========================================
Files 197 198 +1
Lines 21827 22001 +174
Branches 4817 4855 +38
==========================================
+ Hits 14609 14710 +101
- Misses 7218 7291 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue #1563 created to add Cypress tests covering the feature page related code in future PR |
29afa52
to
9b334da
Compare
(Note: Feature toggling is currently disabled and will be enabled in a future PR.)
ZAPP-1547