8000 Exclude Features with Disallowed Conformance from Bitmaps by ethanzhouyc · Pull Request #1524 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Exclude Features with Disallowed Conformance from Bitmaps #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Exclude Features with Disallowed Conformance from Bitmaps #1524

wants to merge 2 commits into from

Conversation

ethanzhouyc
Copy link
Collaborator
@ethanzhouyc ethanzhouyc commented Feb 12, 2025 •
edited
Loading 
      <!-- TODO: ZAP still generates feature bits for things with disallowConform! -->
      <feature bit="0" code="DEPONOFF" name="OnOff" summary="Dependency with the OnOff cluster is disallowed for this cluster">
        <disallowConform/>
      </feature>

With this PR, the OnOff feature will no longer be added to bitmaps in codegen when the above XML configuration is applied.

@ethanzhouyc
Copy link
Collaborator Author
ethanzhouyc commented Feb 12, 2025 •
edited
Loading

This PR fails the Matter codegen CI because it removes disallowed features from bitmaps in codegen, requiring the CHIP repository to be updated by re-running codegen.

@ethanzhouyc ethanzhouyc mentioned this pull request Feb 12, 2025
Closed
@ethanzhouyc
Copy link
Collaborator Author
ethanzhouyc commented Feb 14, 2025 •
edited
Loading

Closing this PR for now as the plan is to add warnings for disallowed features instead of removing them from bitmaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulr34 paulr34 Awaiting requested review from paulr34 paulr34 is a code owner

@tecimovic tecimovic Awaiting requested review from tecimovic tecimovic is a code owner

@brdandu brdandu Awaiting requested review from brdandu brdandu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanzhouyc
0