Add ClusterFuzzLite integration #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
progsource
reviewed
Dec 23, 2023
There was a problem hiding this comment.
Thank you for your contribution!
It would be nice to always have an empty line at the end of the files. And please follow CONTRIBUTING
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| branches: [ master ] |
There was a problem hiding this comment.
Suggested change
| branches: [ master ] | |
| branches: | |
| - master | |
| - dev |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| sanitizer: [address] |
There was a problem hiding this comment.
Maybe it could be good, to also add memory and undefined behavior. What do you think?
| #include <string> | ||
|
|
||
| extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | ||
| std::string payload(reinterpret_cast<const char *>(data), size); |
There was a problem hiding this comment.
Is the reinterpret cast really needed? does
Suggested change
| std::string payload(reinterpret_cast<const char *>(data), size); | |
| std::string payload(data, size); |
not work?
|
In https://github.com/progsource/maddy/actions/runs/7307934736/job/19914831467?pr=54 it says Does there need to be maybe another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fuzzing by way of ClusterFuzzLite, which is a GitHub action that will perform a short amount of fuzzing for new PRs. The goal is to use fuzzing to catch bugs that may be introduced by new PRs.
I added a fuzzer that targets the parsing logic, and currently se 8000 t the timeout of CFLite to 180 seconds. CFLite will flag if the fuzzer finds any issues in the code introduced by a PR.