8000 Use proper required checkboxes syntax by HonkingGoose · Pull Request #1699 · progit/progit2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use proper required checkboxes syntax #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2021
Merged

Use proper required checkboxes syntax #1699

merged 1 commit into from
Aug 15, 2021

Conversation

HonkingGoose
Copy link
Contributor
@HonkingGoose HonkingGoose commented Aug 9, 2021 •
edited
Loading

Changes

  • Use proper required checkboxes syntax

Context

The old forms are not properly forcing some checkboxes to be ticked before proceeding, this PR makes it so that we properly force the checkboxes. 😄

Turns out you need to put the required: true value under the option key, not in a separate validations key... 😄

Example of invalid syntax:

  - type: checkboxes
    attributes:
      label: There's no existing/similar bug report.
      description: Please search to see if an issue already exists for the bug you encountered.
      options:
        - label: I have searched the existing issues
    validations:
      required: true

Example of correct syntax:

  - type: checkboxes
    attributes:
      label: There's no existing/similar bug report.
      description: Please search to see if an issue already exists for the bug you encountered.
      options:
        - label: I have searched the existing issues
          required: true

@ben ben merged commit f829ea7 into progit:main Aug 15, 2021
@HonkingGoose HonkingGoose deleted the chore/improve-forms-required-checkboxes branch August 15, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben ben ben left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HonkingGoose @ben @thanhchauvksdbp
0