Cut v1.3.0-beta.0 #2090
Merged
Cut v1.3.0-beta.0 #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we'll wait for #2078 (comment) |
|
Yes. Otherwise, this looks good to me. |
|
Fix is in . Since this is only a beta version, let's go with that. Perhaps rebase this on top of the fix to avoid confusion. 👍 |
|
Can we get #2096 in also as it's a bugfix? |
|
Yes, please. Feel free to merge #2096 . |
|
Will rebase tomorrow including both fixes, then we'll do the release :) |
|
Rebased and updated the changelog. PTAL @beorn7 @brian-brazil @fabxc |
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change to the Kubernetes service discovery. This is ok as the Kubernetes SD is in beta status. It requires a configuration change. See prometheus/docs#601 for documentation on the configuration.
@brian-brazil @fabxc @juliusv @grobie @beorn7