10000 Stricter Relabel Config Checking for Labeldrop/keep by gouthamve · Pull Request #2510 · prometheus/prometheus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stricter Relabel Config Checking for Labeldrop/keep #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2017
Merged

Stricter Relabel Config Checking for Labeldrop/keep #2510

merged 2 commits into from
Mar 18, 2017

Conversation

gouthamve
Copy link
Member
@gouthamve gouthamve commented Mar 18, 2017 •
edited
Loading

Closes #2368

Too many test files, but don't know how to test it otherwise.

cc @brian-brazil

grobie
grobie approved these changes Mar 18, 2017
View reviewed changes
Copy link
Member
@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If the amount of testfiles becomes an issue, we could think about inlining the YAML configs inside of config_test.go. Something like adding a new attribute config and if that's present, use it over filename.

@juliusv
Copy link
Member
juliusv commented Mar 18, 2017

👍

@juliusv juliusv merged commit 5c89cec into prometheus:master Mar 18, 2017
@gouthamve gouthamve deleted the relabel-validation-2368 branch March 19, 2017 05:15
@tcolgate
Copy link
Contributor
tcolgate commented Jul 4, 2017

This broke configs serialized directly from the prom config struct (#2899). I'd suggest checking the len(source_labels), and probably add omitempty to the source_labels tag to the field in the config struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobie grobie grobie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouthamve @juliusv @tcolgate @grobie
0