feat(scrape): Add configurable namespace metadata enrichment #16796
+1,435
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50cc05a to
f9d8ebe
Compare
Signed-off-by: Mehmet Ali Baykara <mab.baykara@gmail.com>
Signed-off-by: Mehmet Ali Baykara <mab.baykara@gmail.com>
Signed-off-by: Mehmet Ali Baykara <mab.baykara@gmail.com>
Signed-off-by: Mehmet Ali Baykara <mab.baykara@gmail.com>
Signed-off-by: Mehmet Ali Baykara <mab.baykara@gmail.com>
bboreham
requested changes
Jun 30, 2025
Comment on lines
+31
to
+32
| "k8s.io/client-go/kubernetes" | ||
| "k8s.io/client-go/rest" |
There was a problem hiding this comment.
We won't put platform-specific things into the central scrape package.
|
Converting draft, raise PR once is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add namespace enrichment capability to scrape configurations, allowing metrics to be automatically enriched with Kubernetes namespace labels and annotations.
Addresses the long-standing need from #9510
It’s a different approach than #9510. This one does the enrichment during scraping.
That said, it could also work with the service discovery approach described in #9510.