fix(histogram): treat first sample as CounterReset #16696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Library User <lib-user@macbookair.home>
Signed-off-by: Dharma-09 <dharmikgangani786@gmail.com>
|
Hi @jesusvazquez |
krajorama
requested changes
Jun 27, 2025
There was a problem hiding this comment.
Please review the #16575 and spec more carefully. The first sample in a chunk is usually not the first in a series.
The task is to modify these bits of code:
prometheus/tsdb/head_append.go
Line 784 in df4f1df
and
prometheus/tsdb/head_append.go
Line 818 in df4f1df
To have the counter reset, not just empty.
Also modify / write test cases to verify that it works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CounterReset as the counter reset hint for the initial (zero) sample in a new histogram time series. This change aligns with the OpenMetrics spec, which treats the first sample as a synthetic reset point.
Previously, the first sample would default to UnknownCounterReset, which was not technically wrong, but less semantically accurate.
Fixes: #16575