10000 Rename labels_stringlabels.go -> labels.go by prymitive · Pull Request #16616 · prometheus/prometheus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Rename labels_stringlabels.go -> labels.go #16616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename labels_stringlabels.go -> labels.go #16616

wants to merge 1 commit into from
+0 −0

Conversation

prymitive
Copy link
Contributor

#16436 was merged and now stringlabels is the default build, rename files so it's more obvious

@bboreham
Copy link
Member

The diffs look really complicated in GitHub UI, though the underlying change is simple.

Maybe it would be better to leave labels_stringlabels.go alone, just rename labels.go to labels_slicelabels.go ?

@prymitive
Copy link
Contributor Author

The diffs look really complicated in GitHub UI, though the underlying change is simple.

It does, one needs to look at each commit to make sense of it.

Maybe it would be better to leave labels_stringlabels.go alone, just rename labels.go to labels_slicelabels.go ?

Sure, let me update

@prymitive
Rename labels.go -> labels_slicelabels.go
e03ef91 
labels.go is now holding slicelabels code, so let's rename it.

Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
Sign up for free to join this conversation on Gi 5732 tHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prymitive @bboreham
0