8000 Upgrade golang.org/x/exp · Issue #12649 · prometheus/prometheus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade golang.org/x/exp #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitryax opened this issue Aug 4, 2023 · 1 comment · Fixed by #12650
Closed

Upgrade golang.org/x/exp #12649

dmitryax opened this issue Aug 4, 2023 · 1 comment · Fixed by #12650

Comments

@dmitryax
Copy link
dmitryax commented Aug 4, 2023 •
edited
Loading

Proposal

The project uses golang.org/x/exp/slices.SortFunc extensively. Recently golang.org/x/exp got a backward incompatible change to the callback function signature to match the upcoming go1.21 standard library API: golang/exp@302865e#diff-ec22fd7f0aec27f1c6dc503e7dd3960c8f5ab781684218aa59b404ada0d48231R29.

In order to upgrade golang.org/x/exp, all the function usages have to be updated or replaced
@dmitryax dmitryax mentioned this issue Aug 4, 2023
Closed
@gouthamve gouthamve mentioned this issue Aug 4, 2023
Merged
gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 4, 2023
@gouthamve
Update exp package
7c0f669 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 4, 2023
@gouthamve
Update exp package
7b8bef2 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 4, 2023
@gouthamve
Update exp package
d513804 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
@bboreham
Copy link
Member
bboreham commented Aug 5, 2023

I looked up where it was decided to change SortFunc: golang/go#60091 (comment)

gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 6, 2023
@gouthamve
Update exp package
43bd827 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/prometheus that referenced this issue Aug 6, 2023
@gouthamve
Update exp package
fb3c217 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/prometheus that referenced this issue Sep 2, 2023
@gouthamve
Update exp package
9772170 
imo, this is worse in term or readability :(

Fixes prometheus#12649

Signed-off-by: Goutham <gouthamve@gmail.com>
ridwanmsharif pushed a commit to ridwanmsharif/prometheus that referenced this issue Jan 25, 2024
@gouthamve @ridwanmsharif
Update exp package
38f314a 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.
@ridwanmsharif ridwanmsharif mentioned this issue Jan 25, 2024
Merged
ridwanmsharif pushed a commit to ridwanmsharif/prometheus that referenced this issue Jan 25, 2024
@gouthamve @ridwanmsharif
Update exp package
176b615 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif pushed a commit to ridwanmsharif/prometheus that referenced this issue Jan 29, 2024
@gouthamve @ridwanmsharif
Update exp package
43dd9d8 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif pushed a commit to ridwanmsharif/prometheus that referenced this issue Jan 29, 2024
@gouthamve @ridwanmsharif
Update exp package
6b4b57b 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.

Original author:    Goutham Veeramachaneni <gouthamve@gmail.com>

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif added a commit to ridwanmsharif/prometheus that referenced this issue Jan 29, 2024
@ridwanmsharif
Update exp package
5e1c645 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.

Original author:    Goutham Veeramachaneni <gouthamve@gmail.com>

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
bwplotka pushed a commit to GoogleCloudPlatform/prometheus that referenced this issue Jan 30, 2024
@ridwanmsharif @bwplotka
Update exp package
a628082 
Cherrypicked prometheus/prometheus#12650 since I
was running into prometheus/prometheus#12649
and open-telemetry/opentelemetry-collector-contrib#24881
when upgrading the OTel collector.

Original author:    Goutham Veeramachaneni <gouthamve@gmail.com>

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ryantxu ryantxu mentioned this issue Feb 8, 2024
Merged
@TheSpiritXIII TheSpiritXIII mentioned this issue Mar 14, 2024
Closed
@prometheus prometheus locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update exp package gouthamve/prometheus
2 participants
@dmitryax @bboreham
0