8000 chore: use testify instead of testing.Fatal by mmorel-35 · Pull Request #718 · prometheus/common · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: use testify instead of testing.Fatal #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mmorel-35
Copy link
Contributor
@mmorel-35 mmorel-35 commented Nov 7, 2024

This uses testify instead of testing for t.Fatal calls

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testifier/require-error branch from 4269fac to beb99c1 Compare November 7, 2024 19:58
@mmorel-35 mmorel-35 marked this pull request as ready for review November 7, 2024 20:02
Copy link
Member
@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SuperQ SuperQ merged commit ab95209 into prometheus:main Nov 7, 2024
7 checks passed
@mmorel-35 mmorel-35 deleted the testifier/require-error branch November 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0