8000 Accept specs as maps as well as proplists by NelsonVides · Pull Request #181 · prometheus-erl/prometheus.erl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accept specs as maps as well as proplists #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Accept specs as maps as well as proplists #181

merged 1 commit into from
May 22, 2025

Conversation

NelsonVides
Copy link
Member

Following up on #179 and #180, also allow to pass specs as maps instead of only proplists. This also allows to define types for them.

@NelsonVides NelsonVides force-pushed the maps_and_proplists branch from a702889 to 4a8b41b Compare May 22, 2025 07:03
@NelsonVides NelsonVides force-pushed the maps_and_proplists branch from 4a8b41b to b05f4e1 Compare May 22, 2025 07:05
@codecov Codecov
Copy link
codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/prometheus_metric.erl 97.29% <ø> (ø)
src/prometheus_metric_spec.erl 100.00% <100.00%> (ø)
src/prometheus_sup.erl 77.41% <100.00%> (ø)
test/eunit/prometheus_default_metrics_tests.erl 100.00% <100.00%> (ø)
test/eunit/prometheus_metric_spec_tests.erl 96.29% <100.00%> (+0.42%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NelsonVides NelsonVides self-assigned this May 22, 2025
@NelsonVides NelsonVides merged commit e328fea into master May 22, 2025
4 checks passed
@NelsonVides NelsonVides deleted the maps_and_proplists branch May 22, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuratczyk mkuratczyk mkuratczyk approved these changes

@onno-vos-dev onno-vos-dev Awaiting requested review from onno-vos-dev

Assignees

@NelsonVides NelsonVides

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NelsonVides @mkuratczyk
0