You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that by default prometheus won't try to find all loaded
modules implementing a behaviour, as this can be a very expensive
operation (taking many seconds as has been seen in the field). If such
behaviour was desired, it'd require explicitly setting all_loaded for
instrumeters and collectors. The default is the most sane behaviour.
This means that by default prometheus won't try to find all loaded
modules implementing a behaviour, as this can be a very expensive
operation (taking many seconds as has been seen in the field). If such
behaviour was desired, it'd require explicitly setting `all_loaded` for
instrumeters and collectors. The default is the most sane behaviour.
Please note that this a breaking change.
Who is not explicitly defining collectors in application environment will see some metrics disappearing by simply updating the lib to a new minor version.
Please note that this a breaking change. Who is not explicitly defining collectors in application environment will see some metrics disappearing by simply updating the lib to a new minor version.
Fair enough. So you mean this should be released as a 5.0? Can fix if that's the case.
Ideally yes, otherwise it can be explicitly stated in the documentation and/or changelog.
It is a tricky change because if you don't have tests on all your collectors (and on the ones included from libraries) you may not discover the issue before going to production
Ideally yes, otherwise it can be explicitly stated in the documentation and/or changelog. It is a tricky change because if you don't have tests on all your collectors (and on the ones included from libraries) you may not discover the issue before going to production
@NelsonVides can you also release a version of prometheus_ex that allows to use the new 5.0.0?
@albertored would love to, but actually that repo needs a revamp, like creating new CI with all the latest versions of Erlang/Elixir, a new ex_doc, fixing the configs (Mix.Config is deprecated), etc. Maybe you want to contribute a PR cleaning up that one? Would be very appreciated! 😄
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81. Overrides #150.
Note too that this is already fixed in RabbitMQ for example, so it won't break its use-case: rabbitmq/rabbitmq-server@692b6f6
As in the last commit: