8000 fix(cli): add esbuild and esbuild-register to runtime dependencies by aqrln · Pull Request #26361 · prisma/prisma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(cli): add esbuild and esbuild-register to runtime dependencies #26361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix(cli): add esbuild and esbuild-register to runtime dependencies #26361

merged 1 commit into from
Feb 18, 2025

Conversation

aqrln
Copy link
Member
@aqrln aqrln commented Feb 18, 2025

/integration

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/client/runtime/library.js 192.89 KB (0%)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 657.4 KB (0%)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 164.21 KB (0%)
packages/client/runtime/edge-esm.js 163.69 KB (0%)
packages/client/runtime/wasm.js 124.96 KB (0%)
packages/client/runtime/index-browser.js 33.98 KB (0%)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.73 MB (+0.01% 🔺)
packages/client/prisma-client-0.0.0.tgz 4.86 MB (0%)
packages/cli/prisma-0.0.0.tgz 4.11 MB (+0.01% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 898.45 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 975.66 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 996.88 KB (0%)
packages/bundle-size/da-workers-pg-worker/output.tgz 949.32 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 909.63 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 868.87 KB (0%)

@jkomyno jkomyno added this to the 6.4.0 milestone Feb 18, 2025
@aqrln aqrln marked this pull request as ready for review February 18, 2025 17:04
jkomyno
jkomyno approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor
@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: we'll need to get rid of this duplication between cli and @prisma/config

@aqrln
Copy link
Member Author
aqrln commented Feb 18, 2025

Note for the future: we'll need to get rid of this duplication between cli and @prisma/config

Yep. This is just to unblock the release. IMO we shouldn't be bundling @prisma/config in CLI and should depend on it as a normal dependency.

@aqrln aqrln merged commit 718fffe into main Feb 18, 2025
241 of 242 checks passed
@aqrln aqrln deleted the push-rxrkoptlzzms branch February 18, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aqrln @jkomyno
0